Fix encrypted ZFS persistence issue #467
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: VMs with encrypted ZFS storage were reformatting the disk on every reboot, even with KMS or local key provider enabled. Root cause: The is_disk_initialized() check required both LUKS header AND zpool detection for encrypted ZFS (line 1057-1058). However, zpool import is attempted on the raw encrypted device (/dev/vdb1) before LUKS is opened, which always fails since the ZFS pool is inside the LUKS container. Solution: For any encrypted filesystem (ext4 or ZFS), only check for LUKS header presence, since the actual filesystem can only be detected after opening LUKS. This aligns encrypted ZFS handling with encrypted ext4, which was already using this approach. Testing: Verified that ext4 encrypted storage persists correctly with KMS key provider. ZFS testing pending after build completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Encrypted ZFS volumes were reformatted on every reboot because initialization checked for both LUKS header and zpool on the raw encrypted device.
Solution
For encrypted filesystems, only check for LUKS header presence; filesystem detection happens after opening LUKS. Aligns encrypted ZFS with encrypted ext4.
Testing